-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up Parquet Array Reader Module #1483
Labels
enhancement
Any new improvement worthy of a entry in the changelog
Comments
tustvold
added
the
enhancement
Any new improvement worthy of a entry in the changelog
label
Mar 24, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Mar 24, 2022
alamb
pushed a commit
that referenced
this issue
Mar 25, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Apr 13, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Apr 13, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Apr 13, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Apr 13, 2022
alamb
added a commit
that referenced
this issue
Apr 15, 2022
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Apr 15, 2022
alamb
pushed a commit
that referenced
this issue
Apr 15, 2022
tustvold
added a commit
that referenced
this issue
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The parquet/arrow/array_reader.rs is currently sitting pretty at 2984 lines of code. Not only does this make the file difficult to navigate, but it also makes it harder to tell what components have unit test coverage - as there is just a large wall of unit tests at the bottom of the file.
Describe the solution you'd like
New functionality, such as
ByteArrayReader
, has already been split into child modules. We should do the same forStructArrayReader
,MapArrayReader
,NullArrayReader
, etc...Describe alternatives you've considered
The module could be left unchanged.
Additional context
#1246 discovered a lack of any testing of NullArrayReader
The text was updated successfully, but these errors were encountered: