Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use total_cmp from std #2130

Closed
Dandandan opened this issue Jul 22, 2022 · 0 comments · Fixed by #2131
Closed

Use total_cmp from std #2130

Dandandan opened this issue Jul 22, 2022 · 0 comments · Fixed by #2131
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We can use total_cmp from rust std now that it is stable.

Describe the solution you'd like

Remove code for a total_cmp implementation and switch to use std.

Describe alternatives you've considered

Additional context
@Dandandan Dandandan added the enhancement Any new improvement worthy of a entry in the changelog label Jul 22, 2022
@Dandandan Dandandan mentioned this issue Jul 22, 2022
Merged
@alamb alamb changed the title Use total_cmp from std Use total_cmp from std Jul 22, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use total_cmp from std Dandandan/arrow-rs
2 participants
@Dandandan @alamb