Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StructBuilder Does not Verify Child Lengths #2252

Closed
tustvold opened this issue Aug 1, 2022 · 0 comments · Fixed by #2413
Closed

StructBuilder Does not Verify Child Lengths #2252

tustvold opened this issue Aug 1, 2022 · 0 comments · Fixed by #2413
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 1, 2022

Describe the bug

StructBuilder::finish calls ArrayDataBuilder::build_unchecked without verifying the length of the child arrays. This allows forming invalid ArrayData

To Reproduce

Expected behavior

StructBuilder::finish should panic, or return an error, if its children are not all the same length and the same length as its null buffer.

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation logic for StructBuilder::finish
2 participants
@alamb @tustvold