Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Skip for DeltaBitPackDecoder #2281

Closed
tustvold opened this issue Aug 2, 2022 · 1 comment · Fixed by #2393
Closed

Implement Skip for DeltaBitPackDecoder #2281

tustvold opened this issue Aug 2, 2022 · 1 comment · Fixed by #2393
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 2, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

DeltaBitPackDecoder::skip is currently implemented by reading the values to a temporary buffer. The performance of this is likely sub-optimal.

Describe the solution you'd like

It should be possible to avoid reading any values, and only reading the block headers.

Describe alternatives you've considered

Additional context
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Aug 2, 2022
@Ted-Jiang
Copy link
Member

working on

@Ted-Jiang Ted-Jiang mentioned this issue Aug 10, 2022
Merged
@alamb alamb changed the title Implement Skip for DeltaBitPackDecoder Implement Skip for DeltaBitPackDecoder Aug 17, 2022
@alamb alamb added the parquet Changes to the parquet crate label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Skip for DeltaBitPackDecoder Ted-Jiang/arrow-rs
3 participants
@alamb @tustvold @Ted-Jiang