You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There are lots of places in our code when we need to build the data type for a list array:
let data_type = ifOffsetSize::IS_LARGE{DataType::LargeList(field)}else{DataType::List(field)};
There are 2 shortcomings:
We judge the OffsetSize at runtime (I am not sure whether the LLVM could do constant folding on it), however, this computation could be done at compile time.
We have to copy this logic everywhere, which leads to repeated code and it is easy to make mistakes.
Describe the solution you'd like
Add a constant value for List array:
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There are lots of places in our code when we need to build the data type for a list array:
There are 2 shortcomings:
OffsetSize
at runtime (I am not sure whether the LLVM could do constant folding on it), however, this computation could be done at compile time.Describe the solution you'd like
Add a constant value for List array:
Then we can simplify the code to get the data type at runtime:
Describe alternatives you've considered
We could not do this.
Additional context
Related to #2274.
The text was updated successfully, but these errors were encountered: