You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After replacing build_unchecked with build().unwrap() in create_primitive_array in the ipc reader, 5 tests fail:
failures:
---- ipc::reader::tests::read_generated_streams_014 stdout ----
thread 'ipc::reader::tests::read_generated_streams_014' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidArgumentError("-11697 is too small to store in a Decimal128 of precision 3. Min is -999")', arrow/src/ipc/reader.rs:497:18
---- ipc::reader::tests::read_generated_files_014 stdout ----
thread 'ipc::reader::tests::read_generated_files_014' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidArgumentError("-11697 is too small to store in a Decimal128 of precision 3. Min is -999")', arrow/src/ipc/reader.rs:497:18
---- json::reader::tests::test_row_type_validation stdout ----
thread 'json::reader::tests::test_row_type_validation' panicked at 'assertion failed: `(left == right)`
left: `"Json error: Expected JSON record to be an object, found Array([Number(1), String(\"hello\")])"`,
right: `"Json error: Expected JSON record to be an object, found Array [Number(1), String(\"hello\")]"`', arrow/src/json/reader.rs:2624:9
---- ipc::writer::tests::read_and_rewrite_generated_streams_014 stdout ----
thread 'ipc::writer::tests::read_and_rewrite_generated_streams_014' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidArgumentError("-11697 is too small to store in a Decimal128 of precision 3. Min is -999")', arrow/src/ipc/reader.rs:497:18
---- ipc::writer::tests::read_and_rewrite_generated_files_014 stdout ----
thread 'ipc::writer::tests::read_and_rewrite_generated_files_014' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidArgumentError("-11697 is too small to store in a Decimal128 of precision 3. Min is -999")', arrow/src/ipc/reader.rs:497:18
IMO we should probably be validating all of them, I'm not sure why we aren't validating some of them... IPC is inherently not trusted
Originally posted by @tustvold in #2525 (comment)
The text was updated successfully, but these errors were encountered: