Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use total_cmp for floating value ordering and remove nan_ordering feature flag #2613

Closed
viirya opened this issue Aug 30, 2022 · 0 comments · Fixed by #2614
Closed

Use total_cmp for floating value ordering and remove nan_ordering feature flag #2613

viirya opened this issue Aug 30, 2022 · 0 comments · Fixed by #2614
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Aug 30, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

As discussed in #2568, we should use total_cmp for floating value ordering and remove nan_ordering feature flag.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Aug 30, 2022
@viirya viirya mentioned this issue Aug 30, 2022
Merged
@viirya viirya changed the title Use total_cmp for floating value ordering and remove nan_ordering feature flag Use total_cmp for floating value ordering and remove nan_ordering feature flag Aug 30, 2022
@alamb alamb added the arrow Changes to the arrow crate label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use total_cmp for floating value ordering and remove nan_ordering feature flag viirya/arrow-rs
2 participants
@viirya @alamb