Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Replace checked_add/sub().unwrap() with +/- #1924

Merged
merged 1 commit into from Jun 23, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None.
Related to #1918.

Are there any user-facing changes?

No.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 23, 2022
@HaoYang670 HaoYang670 changed the title MINOR: Replace checked_add(sub).unwrap() with +(-) MINOR: Replace checked_add/sub().unwrap() with +/- Jun 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1924 (da82e0c) into master (fc4044f) will decrease coverage by 0.01%.
The diff coverage is 87.45%.

❗ Current head da82e0c differs from pull request most recent head 4c118b3. Consider uploading reports for the commit 4c118b3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   83.43%   83.41%   -0.02%     
==========================================
  Files         203      214      +11     
  Lines       56969    57004      +35     
==========================================
+ Hits        47531    47550      +19     
- Misses       9438     9454      +16     
Impacted Files Coverage Δ
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/compute/kernels/temporal.rs 94.64% <ø> (ø)
arrow/src/datatypes/datatype.rs 65.42% <ø> (-0.38%) ⬇️
parquet/src/column/reader.rs 68.61% <0.00%> (ø)
arrow/src/array/array_binary.rs 94.18% <66.66%> (ø)
arrow/src/array/builder/decimal_builder.rs 69.18% <69.18%> (ø)
arrow/src/array/builder/boolean_builder.rs 75.75% <75.75%> (ø)
arrow/src/array/builder/union_builder.rs 76.99% <76.99%> (ø)
arrow/src/array/builder/struct_builder.rs 77.47% <77.47%> (ø)
.../src/array/builder/primitive_dictionary_builder.rs 78.18% <78.18%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4044f...4c118b3. Read the comment docs.

@tustvold
Copy link
Contributor

This pr appears to have what appears to be a broken rebase?

@HaoYang670
Copy link
Contributor Author

Sorry, I am a little confused about what the broken rebase means?

@tustvold
Copy link
Contributor

It appears to have sorted itself out, it was showing a massive diff of unrelated changes. I think GitHub got confused 😅

@tustvold tustvold merged commit c65bbc5 into apache:master Jun 23, 2022
18 checks passed
@HaoYang670 HaoYang670 deleted the remove_checked_unwrap branch June 23, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants