Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UnionBuilder Constructors #2488

merged 2 commits into from Aug 19, 2022


Copy link

@psvri psvri commented Aug 17, 2022

Which issue does this PR close?

Partially implements #2054

Rationale for this change

Refactor apis to make a consistent new and with_capacity functions

What changes are included in this PR?

introduced funcions with_capacity_sparse and with_capacity_dense and removed capacity option from new functions

Are there any user-facing changes?


@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 17, 2022
Copy link

Could you merge master so that the CI runs clean 🙏

@@ -168,8 +178,8 @@ impl UnionBuilder {

/// Creates a new sparse array builder.
pub fn new_sparse(capacity: usize) -> Self {
Copy link

@tustvold tustvold Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something for this PR but we should probably save the capacity and use it when we create new builder children

Ticket created - #2523

@tustvold tustvold merged commit ac8b0eb into apache:master Aug 19, 2022
20 checks passed
@tustvold tustvold changed the title refactoring union builder apis Refector UnionBuilder Constructors Aug 19, 2022
@tustvold tustvold added the api-change Changes to the arrow API label Aug 19, 2022
@tustvold tustvold changed the title Refector UnionBuilder Constructors Refactor UnionBuilder Constructors Aug 19, 2022
Copy link

ursabot commented Aug 19, 2022

Benchmark runs are scheduled for baseline = 930d2d7 and contender = ac8b0eb. ac8b0eb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

amrltqt pushed a commit to amrltqt/arrow-rs that referenced this pull request Aug 20, 2022
@psvri psvri deleted the unionbuilder_refactor branch September 6, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api-change Changes to the arrow API arrow Changes to the arrow crate
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants