Gate dyn comparison of dictionary arrays behind dyn_cmp_dict
#2597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2596
Rationale for this change
See ticket, improves release compilation times by ~50%.
With dictionary comparison kernels
Without dictionary comparison kernels
What changes are included in this PR?
Adds a new
dyn_cmp_dict
feature flag. I opted to not enable this by default as I think the rarity of people relying on this functionality, combined with the significant bloat reduction I think warrants a breaking change.Are there any user-facing changes?
Yes