Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out arrow-csv (#2594) #3044

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Nov 7, 2022

Which issue does this PR close?

Part of #2594

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 7, 2022
use chrono::prelude::*;

#[test]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are moved to an integration test in the arrow crate

@@ -595,105 +590,6 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo
);
}

#[cfg(feature = "chrono-tz")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to integration test in arrow crate

@@ -265,5 +264,9 @@ harness = false
required-features = ["test_utils"]

[[test]]
name = "ipc_integration"
name = "ipc"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted to remove the redundant integration suffix

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

arrow-csv/Cargo.toml Outdated Show resolved Hide resolved
//! use arrow::datatypes::{DataType, Field, Schema};
//! use std::fs::File;
//! use std::sync::Arc;
//! ```no_run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed to "no_run"? It seems like it is a good thing to keep testing, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the file it reads is no longer part of this crate

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tustvold tustvold merged commit fe3318b into apache:master Nov 8, 2022
@ursabot
Copy link

ursabot commented Nov 8, 2022

Benchmark runs are scheduled for baseline = a950b52 and contender = fe3318b. fe3318b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 8, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 8, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 8, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 8, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 8, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 9, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 9, 2022
tustvold added a commit that referenced this pull request Nov 9, 2022
* Split out arrow-json (#3044)

* RAT

* Fix feature

* Revert no_run

* RAT
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 9, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 10, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 10, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 10, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Nov 10, 2022
tustvold added a commit that referenced this pull request Nov 10, 2022
tustvold added a commit that referenced this pull request Nov 10, 2022
* Update parquet to depend on arrow subcrates (#3044)

* Fix parquet_derive

* Fix parquet_derive

* Fix no-default-features test compilation

* Fix parquet-fromcsv

* Clippy
tustvold added a commit that referenced this pull request Nov 11, 2022
* Move CSV test data (#3044)

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants