Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused range module #3085

merged 1 commit into from
Nov 11, 2022


Copy link

Which issue does this PR close?

Closes #.

Rationale for this change

This was added by @Ted-Jiang in #1791 but hasn't ever been hooked up. It overlaps sufficiently with the RowSelector logic, that I think it can be removed.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 10, 2022
@@ -17,6 +17,3 @@

pub mod index;
pub mod index_reader;

pub(crate) mod range;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it is only for test?

@tustvold tustvold merged commit 0139682 into apache:master Nov 11, 2022
Copy link

ursabot commented Nov 11, 2022

Benchmark runs are scheduled for baseline = 5226258 and contender = 0139682. 0139682 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Copy link

@tustvold Thanks, It can be removed, I have intended to use bytes offset as input, now use the selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
parquet Changes to the parquet crate
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants