From ce3008ed9930018f121661c076c96b8b8199624d Mon Sep 17 00:00:00 2001
From: Andrew Lamb <andrew@nerdnetworks.org>
Date: Tue, 25 May 2021 17:37:02 -0400
Subject: [PATCH] Disable MIRI check until it runs cleanly on CI

---
 .github/workflows/rust.yml | 71 ++++++++++++++++++++------------------
 1 file changed, 37 insertions(+), 34 deletions(-)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 906305e3742..77c1f0fb3e9 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -230,40 +230,43 @@ jobs:
           export CARGO_TARGET_DIR="/github/home/target"
           cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
 
-  miri-checks:
-    name: MIRI
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        arch: [amd64]
-        rust: [nightly-2021-03-24]
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: true
-      - uses: actions/cache@v2
-        with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target
-          key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
-      - name: Setup Rust toolchain
-        run: |
-          rustup toolchain install ${{ matrix.rust }}
-          rustup default ${{ matrix.rust }}
-          rustup component add rustfmt clippy miri
-      - name: Run Miri Checks
-        env:
-          RUST_BACKTRACE: full
-          RUST_LOG: 'trace'
-        run: |
-          export MIRIFLAGS="-Zmiri-disable-isolation"
-          cargo miri setup
-          cargo clean
-          # Currently only the arrow crate is tested with miri 
-          # IO related tests and some unsupported tests are skipped
-          cargo miri test -p arrow -- --skip csv --skip ipc --skip json
+  # MIRI checks are disabled until they runs cleanly:
+  # https://github.com/apache/arrow-rs/issues/345
+  #
+  # miri-checks:
+  #   name: MIRI
+  #   runs-on: ubuntu-latest
+  #   strategy:
+  #     matrix:
+  #       arch: [amd64]
+  #       rust: [nightly-2021-03-24]
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #       with:
+  #         submodules: true
+  #     - uses: actions/cache@v2
+  #       with:
+  #         path: |
+  #           ~/.cargo/registry
+  #           ~/.cargo/git
+  #           target
+  #         key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+  #     - name: Setup Rust toolchain
+  #       run: |
+  #         rustup toolchain install ${{ matrix.rust }}
+  #         rustup default ${{ matrix.rust }}
+  #         rustup component add rustfmt clippy miri
+  #     - name: Run Miri Checks
+  #       env:
+  #         RUST_BACKTRACE: full
+  #         RUST_LOG: 'trace'
+  #       run: |
+  #         export MIRIFLAGS="-Zmiri-disable-isolation"
+  #         cargo miri setup
+  #         cargo clean
+  #         # Currently only the arrow crate is tested with miri
+  #         # IO related tests and some unsupported tests are skipped
+  #         cargo miri test -p arrow -- --skip csv --skip ipc --skip json || true
 
   lint:
     name: Lint