Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print container logs in CI #5286

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 5, 2024

Which issue does this PR close?

Part of #5283

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@@ -121,10 +121,12 @@ jobs:
steps:
- uses: actions/checkout@v4

# We are forced to use docker commands instead of service containers as we need to override the entrypoints
Copy link
Contributor Author

@tustvold tustvold Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their reticence to add support for this would suggest the runner is talking to the docker daemon using the CLI instead of the gRPC API, which is kind of terrifying

@tustvold tustvold added the development-process Related to development process of arrow-rs label Jan 5, 2024
@tustvold tustvold marked this pull request as ready for review January 5, 2024 12:29
@tustvold
Copy link
Contributor Author

tustvold commented Jan 5, 2024

This only impacts CI and is non-controversial so merging

@tustvold tustvold merged commit 2e86650 into apache:master Jan 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant