From b672e5c9903221c345dfdc582bfc39769dca9719 Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Wed, 28 Sep 2022 10:03:42 -0500 Subject: [PATCH] ARROW-17865: [Java] Deprecate Java Plasma JNI bindings (#14262) Deprecate Java Plasma JNI bindings based on https://lists.apache.org/thread/nw232k2lzmg9kcl8ts475m9ybl34j81p Authored-by: david dali susanibar arce Signed-off-by: David Li --- java/plasma/README.md | 2 ++ java/plasma/pom.xml | 3 ++- .../main/java/org/apache/arrow/plasma/ObjectStoreLink.java | 3 +++ .../src/main/java/org/apache/arrow/plasma/PlasmaClient.java | 3 +++ .../main/java/org/apache/arrow/plasma/PlasmaClientJNI.java | 3 +++ .../arrow/plasma/exceptions/DuplicateObjectException.java | 3 +++ .../apache/arrow/plasma/exceptions/PlasmaClientException.java | 3 +++ .../arrow/plasma/exceptions/PlasmaOutOfMemoryException.java | 3 +++ .../test/java/org/apache/arrow/plasma/PlasmaClientTest.java | 4 ++++ 9 files changed, 26 insertions(+), 1 deletion(-) diff --git a/java/plasma/README.md b/java/plasma/README.md index 0dcb4e21f864f..d3c936f6f2b32 100644 --- a/java/plasma/README.md +++ b/java/plasma/README.md @@ -19,6 +19,8 @@ # Java Plasma Client +This is deprecated since 10.0.0. This will be removed from 12.0.0 or so. + ## Setup Build Environment Install: diff --git a/java/plasma/pom.xml b/java/plasma/pom.xml index a9281d44e9a6e..7b643501521dc 100644 --- a/java/plasma/pom.xml +++ b/java/plasma/pom.xml @@ -18,7 +18,8 @@ arrow-plasma Arrow Plasma Client - (Experimental/Contrib) Java client for the Plasma object store. + (DEPRECATED) Java client for the Plasma object store. + This is deprecated since 10.0.0. This will be removed from 12.0.0 or so. diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/ObjectStoreLink.java b/java/plasma/src/main/java/org/apache/arrow/plasma/ObjectStoreLink.java index 93a2d483c4891..76793ffee117d 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/ObjectStoreLink.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/ObjectStoreLink.java @@ -24,7 +24,10 @@ /** * Object store interface, which provides the capabilities to put and get raw byte array, and serves. + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public interface ObjectStoreLink { /** diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClient.java b/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClient.java index fdd7114f17503..6705e2f2fdc8f 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClient.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClient.java @@ -30,7 +30,10 @@ * *

The PlasmaClient can ask the PlasmaStore to allocate a new buffer, seal a buffer, and get a * buffer. Buffers are referred to by object IDs. + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public class PlasmaClient implements ObjectStoreLink { private final long conn; diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClientJNI.java b/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClientJNI.java index da5c17e6be02e..8a45201c8e079 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClientJNI.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/PlasmaClientJNI.java @@ -24,7 +24,10 @@ /** * JNI static methods for PlasmaClient. + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public class PlasmaClientJNI { public static native long connect(String storeSocketName, String managerSocketName, int releaseDelay); diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/DuplicateObjectException.java b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/DuplicateObjectException.java index cb735282cea5b..f0cfb1fff3cd0 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/DuplicateObjectException.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/DuplicateObjectException.java @@ -19,7 +19,10 @@ /** * Thrown when attempting to place an object into the store for an ID that already exists. + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public class DuplicateObjectException extends RuntimeException { public DuplicateObjectException(String objectId) { diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaClientException.java b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaClientException.java index ff9d96b172436..cb97b6980fca3 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaClientException.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaClientException.java @@ -19,7 +19,10 @@ /** * Generic exception thrown by the plasma client (for example on failure to connect). + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public class PlasmaClientException extends RuntimeException { public PlasmaClientException(String message) { diff --git a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java index ffc4177ebbe30..6462cd5dff1e0 100644 --- a/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java +++ b/java/plasma/src/main/java/org/apache/arrow/plasma/exceptions/PlasmaOutOfMemoryException.java @@ -19,7 +19,10 @@ /** * Indicates no more memory is available in Plasma. + * + * @deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. */ +@Deprecated public class PlasmaOutOfMemoryException extends RuntimeException { public PlasmaOutOfMemoryException(String message) { diff --git a/java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java b/java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java index e02ee51f9ed0e..f9bfac4c56cf4 100644 --- a/java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java +++ b/java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java @@ -29,6 +29,10 @@ import org.apache.arrow.plasma.exceptions.PlasmaOutOfMemoryException; import org.junit.Assert; +/* + * @Deprecated Plasma is deprecated since 10.0.0. Plasma will not be released from Apache Arrow 12.0.0 or so. + */ +@Deprecated public class PlasmaClientTest { private String storeSuffix = "/tmp/store";