Skip to content
Permalink
Browse files
ARROW-4737: run C# tests in CI
The C# tests aren't running in CI because they are being filtered out. Adding detection logic for C#, so the tests run when `csharp` code changes.

@wesm @chutchinson @pgovind

Author: Eric Erhardt <eric.erhardt@microsoft.com>

Closes #3788 from eerhardt/FixCSharpCI and squashes the following commits:

7aaf8aa <Eric Erhardt> ARROW-4737: run C# tests in CI
  • Loading branch information
eerhardt authored and xhochy committed Mar 3, 2019
1 parent b1edd3e commit c35a3e6e6c5e87490489f4709997646f7c0ec7e8
Showing with 11 additions and 2 deletions.
  1. +7 −0 ci/appveyor-filter-changes.bat
  2. +4 −2 ci/detect-changes.py
@@ -29,6 +29,13 @@ if "%JOB%" == "Rust" (
echo ===
appveyor exit
)
) else if "%JOB%" == "C#" (
if "%ARROW_CI_CSHARP_AFFECTED%" == "0" (
echo ===
echo === No C# changes, exiting job
echo ===
appveyor exit
)
) else (
if "%ARROW_CI_PYTHON_AFFECTED%" == "0" (
echo ===
@@ -108,7 +108,7 @@ def list_appveyor_affected_files():


LANGUAGE_TOPICS = ['c_glib', 'cpp', 'docs', 'go', 'java', 'js', 'python',
'r', 'ruby', 'rust']
'r', 'ruby', 'rust', 'csharp']

ALL_TOPICS = LANGUAGE_TOPICS + ['integration', 'site', 'dev']

@@ -124,7 +124,7 @@ def list_appveyor_affected_files():
}

COMPONENTS = {'cpp', 'java', 'c_glib', 'r', 'ruby', 'integration', 'js',
'rust', 'site', 'go', 'docs', 'python', 'dev'}
'rust', 'csharp', 'site', 'go', 'docs', 'python', 'dev'}


def get_affected_topics(affected_files):
@@ -241,6 +241,7 @@ def test_get_affected_topics():
'r': True,
'ruby': True,
'rust': False,
'csharp': False,
'integration': True,
'site': False,
'dev': False
@@ -258,6 +259,7 @@ def test_get_affected_topics():
'r': True,
'ruby': True,
'rust': True,
'csharp': True,
'integration': True,
'site': False,
'dev': False

0 comments on commit c35a3e6

Please sign in to comment.