Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Implement/test dictionary-encoded subfields #16864

Closed
3 tasks done
asfimport opened this issue Jul 2, 2017 · 7 comments
Closed
3 tasks done

[Java] Implement/test dictionary-encoded subfields #16864

asfimport opened this issue Jul 2, 2017 · 7 comments

Comments

@asfimport
Copy link

asfimport commented Jul 2, 2017

We do not have any tests about types like:

List<Dictionary-encoded String>

cc @julienledem @elahrvivaz

Reporter: Wes McKinney / @wesm
Assignee: Ji Liu / @tianchen92

Subtasks:

Note: This issue was originally created as ARROW-1175. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Emilio Lahr-Vivaz / @elahrvivaz:
Some more details - the important bit is calling 'vector.addOrGet' with the correct dictionary encoded field. This sets up the metadata correctly. The child vector is of the dictionary encoded type (e.g. Int), and you have to manually encode dictionary values before writing them. On read, you have to examine the schema so that you know to manually decode the Int values appropriately.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Cool, after we get the integration tests working for flat data I will add integration tests for encoded subfields and we can address any issues that come up

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Moving this off 0.6.0 as not urgent. It would be good to have unit tests for this, though. cc @icexelloss

@asfimport
Copy link
Author

Wes McKinney / @wesm:
[~emkornfield@gmail.com] I might put this on your radar for some point in the future, moving out of 0.14.0 for now

@asfimport
Copy link
Author

Ji Liu / @tianchen92:
If [~emkornfield@gmail.com] don't mind, I would like to take this issue:).

@asfimport
Copy link
Author

Micah Kornfield / @emkornfield:
SGTM, in general, I think if issues are unassigned they are up for anyone to take on.

@asfimport asfimport added this to the 0.16.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants