Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Build fails due to missing Ninja #34029

Closed
abetomo opened this issue Feb 3, 2023 · 2 comments · Fixed by #34040
Closed

[Docs] Build fails due to missing Ninja #34029

abetomo opened this issue Feb 3, 2023 · 2 comments · Fixed by #34040

Comments

@abetomo
Copy link
Contributor

abetomo commented Feb 3, 2023

Describe the bug, including details regarding any error messages, version, and platform.

I built it on Ubuntu22.04 according to Building Arrow C++.
Then I get an error.

$ cmake .. --preset ninja-debug-minimal
Preset CMake variables:

  ARROW_BUILD_INTEGRATION="OFF"
  ARROW_BUILD_STATIC="OFF"
  ARROW_BUILD_TESTS="OFF"
  ARROW_EXTRA_ERROR_CONTEXT="ON"
  ARROW_WITH_RE2="OFF"
  ARROW_WITH_UTF8PROC="OFF"
  CMAKE_BUILD_TYPE="Debug"

-- Building using CMake version: 3.22.1
CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
See also "/home/xxx/arrow/cpp/build/CMakeFiles/CMakeOutput.log".

After installing ninja-build, I can build.

I propose to update the document.

diff --git a/docs/source/developers/cpp/building.rst b/docs/source/developers/cpp/building.rst
index 3b065aa40..ea7f08440 100644
--- a/docs/source/developers/cpp/building.rst
+++ b/docs/source/developers/cpp/building.rst
@@ -53,6 +53,7 @@ On Ubuntu/Debian you can install the requirements with:

    sudo apt-get install \
         build-essential \
+        ninja-build \
         cmake

 On Alpine Linux:

Component(s)

Documentation

@westonpace
Copy link
Member

Can you propose your diff as a PR. It looks like a good addition to me. You can (I think) click the "edit" icon on https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/building.rst and create a PR that way.

@kou kou changed the title [Docs] Build fails due to missing Ninja. [Docs] Build fails due to missing Ninja Feb 4, 2023
abetomo added a commit to abetomo/arrow that referenced this issue Feb 4, 2023
Install `ninja-build` because the build fails due to missing Ninja.

Signed-off-by: abetomo <abe@enzou.tokyo>
@abetomo
Copy link
Contributor Author

abetomo commented Feb 4, 2023

Thank you for your comment.
I have opened #34040.

abetomo added a commit to abetomo/arrow that referenced this issue Feb 6, 2023
Install Ninja because the build fails due to missing Ninja.

Signed-off-by: abetomo <abe@enzou.tokyo>
westonpace pushed a commit that referenced this issue Feb 6, 2023
### Rationale for this change

I built it on Ubuntu22.04 according to [Building Arrow C++](https://arrow.apache.org/docs/dev/developers/cpp/building.html).
Then the build will fail due to missing Ninja.

### What changes are included in this PR?

Update document to also install `ninja-build`.

### Are these changes tested?

Document updates only.

### Are there any user-facing changes?

* Closes: #34029

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Feb 6, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
### Rationale for this change

I built it on Ubuntu22.04 according to [Building Arrow C++](https://arrow.apache.org/docs/dev/developers/cpp/building.html).
Then the build will fail due to missing Ninja.

### What changes are included in this PR?

Update document to also install `ninja-build`.

### Are these changes tested?

Document updates only.

### Are there any user-facing changes?

* Closes: apache#34029

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
### Rationale for this change

I built it on Ubuntu22.04 according to [Building Arrow C++](https://arrow.apache.org/docs/dev/developers/cpp/building.html).
Then the build will fail due to missing Ninja.

### What changes are included in this PR?

Update document to also install `ninja-build`.

### Are these changes tested?

Document updates only.

### Are there any user-facing changes?

* Closes: apache#34029

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
### Rationale for this change

I built it on Ubuntu22.04 according to [Building Arrow C++](https://arrow.apache.org/docs/dev/developers/cpp/building.html).
Then the build will fail due to missing Ninja.

### What changes are included in this PR?

Update document to also install `ninja-build`.

### Are these changes tested?

Document updates only.

### Are there any user-facing changes?

* Closes: apache#34029

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants