Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bundled ORC may not use the same ProtoBuf #34191

Closed
kou opened this issue Feb 15, 2023 · 0 comments · Fixed by #34192
Closed

[C++] Bundled ORC may not use the same ProtoBuf #34191

kou opened this issue Feb 15, 2023 · 0 comments · Fixed by #34192
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
12.0.0

Comments

@kou
Copy link
Member

kou commented Feb 15, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

We may specify wrong -DPROTO* values when we use bundled ORC. Because FindProtobuf.cmake provided by CMake and protobuf-config.cmake provided by ProtoBuf is incompatible. If we specify wrong -DPROTO* values, ORC uses bundled ProtoBuf. It may conflict ProtoBuf used by Arrow.

Homebrew/homebrew-core#121566 hits this problem.

Component(s)

C++
@kou kou added the Type: bug label Feb 15, 2023
kou added a commit to kou/arrow that referenced this issue Feb 15, 2023
@kou
apacheGH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC
b0d57ec
@github-actions github-actions bot mentioned this issue Feb 15, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Feb 15, 2023
@kou
apacheGH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC
55535f5
@kou kou mentioned this issue Feb 15, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Feb 17, 2023
@kou
apacheGH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC
9f5ac7d
kou added a commit that referenced this issue Feb 20, 2023
@kou
GH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC (#34192)
7db7e6a 
### Rationale for this change

We can't detect correct ProtoBuf related values to pass bundled ORC with the current approach.

### What changes are included in this PR?

This change uses generator expression to get `CONFIG` depended value correctly.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #34191

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Feb 20, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@kou @fatemehp
apacheGH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC (a…
2991379 
…pache#34192)

### Rationale for this change

We can't detect correct ProtoBuf related values to pass bundled ORC with the current approach.

### What changes are included in this PR?

This change uses generator expression to get `CONFIG` depended value correctly.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#34191

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@wgtmac wgtmac mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34191: [C++] Ensure using the same ProtoBuf in bundled ORC kou/arrow
1 participant
@kou