Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Improve the performance for Decoding DELTA_LENGTH_BYTE_ARRAY #34335

Closed
mapleFU opened this issue Feb 24, 2023 · 0 comments · Fixed by #34955
Closed

[C++][Parquet] Improve the performance for Decoding DELTA_LENGTH_BYTE_ARRAY #34335

mapleFU opened this issue Feb 24, 2023 · 0 comments · Fixed by #34955
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
12.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Feb 24, 2023

Describe the enhancement requested

To be honest, the previous logic is too slow. It's 20 time slower than PLAIN for ByteArray. I'll do some optimizations on it.

Component(s)

C++, Parquet
@github-actions github-actions bot mentioned this issue Feb 24, 2023
Closed
@github-actions github-actions bot mentioned this issue Apr 7, 2023
Merged
wjones127 pushed a commit that referenced this issue Apr 8, 2023
@mapleFU
GH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_ARRAY (#…
28ca876 
…34955)

### Rationale for this change

According to #34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #34335

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
@wjones127 wjones127 added this to the 12.0.0 milestone Apr 8, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@mapleFU @liujiacheng777
apacheGH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_AR…
5f3d97d 
…RAY (apache#34955)

### Rationale for this change

According to apache#34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34335

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@mapleFU @ArgusLi
apacheGH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_AR…
ed630c7 
…RAY (apache#34955)

### Rationale for this change

According to apache#34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34335

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@mapleFU @rtpsw
apacheGH-34335: [C++][Parquet] Optimize Decoding DELTA_LENGTH_BYTE_AR…
8778d2e 
…RAY (apache#34955)

### Rationale for this change

According to apache#34323 . DELTA_LENGTH_BYTE_ARRAY is much more slower. So do some optimizations.

### What changes are included in this PR?

Some tiny changes

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#34335

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
12.0.0
2 participants
@wjones127 @mapleFU