Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Build compute without noasm for non-amd64 GOARCH and Go 1.18 and up #34839

Closed
nwt opened this issue Apr 2, 2023 · 0 comments · Fixed by #34840
Closed

[Go] Build compute without noasm for non-amd64 GOARCH and Go 1.18 and up #34839

nwt opened this issue Apr 2, 2023 · 0 comments · Fixed by #34840
Assignees
@nwt
Labels
Component: Go Type: enhancement
Milestone
12.0.0

Comments

@nwt
Copy link
Contributor

nwt commented Apr 2, 2023

Describe the enhancement requested

Building github.com/apache/arrow/go/v12/arrow/compute for a non-amd64 GOARCH with Go 1.18 and up requires -tag=noasm. It'd be nice if it didn't.

$ go version
go version go1.20.2 darwin/arm64

$ go build -tags=noasm github.com/apache/arrow/go/v12/arrow/compute && echo success
success

$ go build github.com/apache/arrow/go/v12/arrow/compute
# github.com/apache/arrow/go/v12/arrow/compute/internal/kernels
arrow/compute/internal/kernels/base_arithmetic.go:816:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:818:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:820:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:822:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:824:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:826:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:828:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:830:10: undefined: getArithmeticOpIntegral
arrow/compute/internal/kernels/base_arithmetic.go:832:10: undefined: getArithmeticOpFloating
arrow/compute/internal/kernels/base_arithmetic.go:834:10: undefined: getArithmeticOpFloating
arrow/compute/internal/kernels/base_arithmetic.go:834:10: too many errors

Component(s)

Go
@github-actions github-actions bot mentioned this issue Apr 2, 2023
Merged
@zeroshade zeroshade added this to the 12.0.0 milestone Apr 3, 2023
zeroshade pushed a commit that referenced this issue Apr 3, 2023
@nwt
GH-34839: [Go] Build compute without noasm for non-amd64 GOARCH (#34840)
0e1f5c6 
Building github.com/apache/arrow/go/v12/arrow/compute for a non-amd64 GOARCH requires -tag=noasm.  Adjust some build constraints so -tag=noasm isn't required.
* Closes: #34839

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue May 6, 2023
Closed
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@nwt @ArgusLi
apacheGH-34839: [Go] Build compute without noasm for non-amd64 GOARCH (…
4df364f 
…apache#34840)

Building github.com/apache/arrow/go/v12/arrow/compute for a non-amd64 GOARCH requires -tag=noasm.  Adjust some build constraints so -tag=noasm isn't required.
* Closes: apache#34839

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@nwt @rtpsw
apacheGH-34839: [Go] Build compute without noasm for non-amd64 GOARCH (…
6125b22 
…apache#34840)

Building github.com/apache/arrow/go/v12/arrow/compute for a non-amd64 GOARCH requires -tag=noasm.  Adjust some build constraints so -tag=noasm isn't required.
* Closes: apache#34839

Authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwt nwt

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34839: [Go] Build compute without noasm for non-amd64 GOARCH nwt/arrow
2 participants
@zeroshade @nwt