-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12591: [Java][Gandiva] Create single Gandiva jar for MacOS and Linux #10189
ARROW-12591: [Java][Gandiva] Create single Gandiva jar for MacOS and Linux #10189
Conversation
5de072e
to
cc5d954
Compare
@github-actions crossbow submit -g gandiva-jar |
@github-actions crossbow submit -g gandiva |
Revision: cc5d954 Submitted crossbow builds: ursacomputing/crossbow @ actions-354
|
cc5d954
to
98bdfe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I hope that we also build all other Java packages building in our release process ( https://github.com/apache/arrow/blob/master/dev/release/post-11-java.sh ) like this as the next task. We can just upload all Java packages including the Gandiva Java package in our release process by the next task.
- name: Upload Artifacts | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: ubuntu-shared-lib-{{ '${{ github.sha }}' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need -{{ '${{ github.sha }}' }}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put just to generate a unique artifact name, but I think it is not necessary, I removed it.
@kou All suggestions were applied. |
@github-actions crossbow submit gandiva-jar |
Revision: f7ae163 Submitted crossbow builds: ursacomputing/crossbow @ actions-363
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…Linux Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems. Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux Authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou I am interested in executing that task. Is there some opened JIRA ticket for it? Or should I create a new one? |
Great! Could you create a new JIRA issue for it? In the task, we need to do the followings:
We'll update https://github.com/apache/arrow/blob/master/dev/release/post-11-java.sh and related release related scripts after the task. |
@kou I created the JIRA issue https://issues.apache.org/jira/browse/ARROW-12699. I will start to work on it. |
…Linux Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems. Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux Authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…Linux Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems. Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux Authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems.