Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12591: [Java][Gandiva] Create single Gandiva jar for MacOS and Linux #10189

Conversation

anthonylouisbsb
Copy link
Contributor

Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems.

@github-actions
Copy link

@anthonylouisbsb anthonylouisbsb force-pushed the feature/create-single-jar-macos-linux branch from 5de072e to cc5d954 Compare April 28, 2021 18:16
@projjal
Copy link
Contributor

projjal commented Apr 29, 2021

@github-actions crossbow submit -g gandiva-jar

@projjal
Copy link
Contributor

projjal commented Apr 29, 2021

@github-actions crossbow submit -g gandiva

@github-actions
Copy link

Revision: cc5d954

Submitted crossbow builds: ursacomputing/crossbow @ actions-354

Task Status
gandiva-jar Github Actions

@anthonylouisbsb anthonylouisbsb force-pushed the feature/create-single-jar-macos-linux branch from cc5d954 to 98bdfe0 Compare April 29, 2021 12:43
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I hope that we also build all other Java packages building in our release process ( https://github.com/apache/arrow/blob/master/dev/release/post-11-java.sh ) like this as the next task. We can just upload all Java packages including the Gandiva Java package in our release process by the next task.

dev/tasks/gandiva-jars/check_shared_dependencies.sh Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/check_shared_dependencies.sh Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/check_shared_dependencies.sh Outdated Show resolved Hide resolved
dev/tasks/tasks.yml Outdated Show resolved Hide resolved
- name: Upload Artifacts
uses: actions/upload-artifact@v2
with:
name: ubuntu-shared-lib-{{ '${{ github.sha }}' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need -{{ '${{ github.sha }}' }}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put just to generate a unique artifact name, but I think it is not necessary, I removed it.

dev/tasks/gandiva-jars/github.linux.macos.yml Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/github.linux.macos.yml Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/github.linux.macos.yml Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/check_shared_dependencies.sh Outdated Show resolved Hide resolved
dev/tasks/gandiva-jars/check_shared_dependencies.sh Outdated Show resolved Hide resolved
@anthonylouisbsb
Copy link
Contributor Author

@kou All suggestions were applied.

@kou
Copy link
Member

kou commented Apr 30, 2021

@github-actions crossbow submit gandiva-jar

@github-actions
Copy link

Revision: f7ae163

Submitted crossbow builds: ursacomputing/crossbow @ actions-363

Task Status
gandiva-jar Github Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 2746266 Apr 30, 2021
@anthonylouisbsb anthonylouisbsb deleted the feature/create-single-jar-macos-linux branch May 5, 2021 01:29
DileepSrigiri pushed a commit to DileepSrigiri/arrow that referenced this pull request May 6, 2021
…Linux

Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems.

Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@anthonylouisbsb
Copy link
Contributor Author

Thanks!

I hope that we also build all other Java packages building in our release process ( https://github.com/apache/arrow/blob/master/dev/release/post-11-java.sh ) like this as the next task. We can just upload all Java packages including the Gandiva Java package in our release process by the next task.

@kou I am interested in executing that task. Is there some opened JIRA ticket for it? Or should I create a new one?

@kou
Copy link
Member

kou commented May 8, 2021

Great!

Could you create a new JIRA issue for it?
The new JIRA issue is a child of ARROW-11135 like ARROW-12591.

In the task, we need to do the followings:

  1. Rename the gandiva-jar task to java-jar
  2. Build all Java packages in the task

We'll update https://github.com/apache/arrow/blob/master/dev/release/post-11-java.sh and related release related scripts after the task.

@anthonylouisbsb
Copy link
Contributor Author

@kou I created the JIRA issue https://issues.apache.org/jira/browse/ARROW-12699.

I will start to work on it.

michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
…Linux

Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems.

Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
…Linux

Today, there are two different tasks that generate Gandiva's jars for MacOS and Linux. The objective is to create a single jar with the shared lib for the two operating systems.

Closes apache#10189 from anthonylouisbsb/feature/create-single-jar-macos-linux

Authored-by: Anthony Louis <anthony@simbioseventures.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants