ARROW-13485: [Release] Replace ${PREVIOUS_RELEASE}.9000 in r/NEWS.md by post-12-bump-versions.sh #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp-versions.sh We need this because we changed to use release branch style.
| @@ -121,18 +121,15 @@ update_versions() { | |||
| DESCRIPTION | |||
| rm -f DESCRIPTION.bak | |||
| git add DESCRIPTION | |||
| # Replace dev version with release version | |||
There was a problem hiding this comment.
I think there's another gap here with regards to patch releases since that version bump goes on top of the previous major release branch. It's fine as long as there is a news entry corresponding to the patch release before the script is run, but if not, this will overwrite the current release version entry. I'm not sure there's a great solution to this.
There was a problem hiding this comment.
I didn't confirm carefully but this will work well by running the following command on maint-X.Y.x branch after we release X.Y.0:
BUMP_DEFAULT=0 BUMP_VERSION_POST_TAG=1 dev/release/post-12-bump-versions.sh X.Y.0 X.Y.1
|
@kszucs Do you want to review this? |
|
I'll merge this. |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Aug 17, 2021
…by post-12-bump-versions.sh We need this because we changed to use release branch style. Closes apache#10828 from kou/release-update-version-r Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this because we changed to use release branch style.