Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-1536:[C++] Do not transitively depend on libboost_system #1105

Closed
wants to merge 3 commits into from

Conversation

@majetideepak
Copy link
Contributor

majetideepak commented Sep 17, 2017

No description provided.

@majetideepak majetideepak force-pushed the majetideepak:ARROW-1536 branch 2 times, most recently from b7c4e7b to bf801cd Sep 17, 2017
@asfgit asfgit force-pushed the apache:master branch from 40e72f5 to 59b24ba Sep 17, 2017
Copy link
Member

wesm left a comment

This looks like a fine solution, thank you! I left a couple comments; this may also need a make format

namespace io {
const char* c_str() const { return utf8_path.c_str(); }

const std::string string() const { return utf8_path; }

This comment has been minimized.

Copy link
@wesm

wesm Sep 18, 2017

Member

const std::string&

This comment has been minimized.

Copy link
@majetideepak

majetideepak Sep 18, 2017

Author Contributor

done!

} catch (boost::system::system_error& e) {
return Status::Invalid(e.what());
}
#else
PlatformFilename::Init(file_name, &file_name_);

This comment has been minimized.

Copy link
@wesm

wesm Sep 18, 2017

Member

I think it may be simpler to do file_name_ = PlatformFilename{file_name}, then you don't even need the Init method I don't think

@wesm

This comment has been minimized.

Copy link
Member

wesm commented Sep 18, 2017

Can you also rebase? thanks

@majetideepak majetideepak force-pushed the majetideepak:ARROW-1536 branch from bf801cd to 6239925 Sep 18, 2017
Deepak Majeti
@majetideepak majetideepak force-pushed the majetideepak:ARROW-1536 branch from 6239925 to 9f4ed61 Sep 19, 2017
@wesm
wesm approved these changes Sep 19, 2017
Copy link
Member

wesm left a comment

+1

@asfgit asfgit closed this in c4f5a12 Sep 20, 2017
@majetideepak majetideepak deleted the majetideepak:ARROW-1536 branch Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.