Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14054: [C++][Docs] Simplify C++ row conversion example #11197

Closed
wants to merge 6 commits into from
Closed

ARROW-14054: [C++][Docs] Simplify C++ row conversion example #11197

wants to merge 6 commits into from

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Sep 21, 2021

  • Add explanations for code example
  • Print out entries
  • make variable names clearer

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-14054

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

pitrou
pitrou reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Some comments.

cpp/examples/arrow/row_wise_conversion_example.cc Outdated Show resolved Hide resolved
cpp/examples/arrow/row_wise_conversion_example.cc Outdated Show resolved Hide resolved
@pitrou
Copy link
Member

pitrou commented Sep 21, 2021

@amol- Since you're getting acquainted with Arrow C++, what do you think about this?

@bkmgit
Copy link
Contributor Author

bkmgit commented Sep 21, 2021

Thanks for the feedback. Will incorporate this.

@kou kou changed the title ARROW-14054: [C++] [Docs] Simplify C++ row conversion example ARROW-14054: [C++][Docs] Simplify C++ row conversion example Sep 21, 2021
pitrou
pitrou requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. A couple more comments below.

cpp/examples/arrow/row_wise_conversion_example.cc Outdated Show resolved Hide resolved
cpp/examples/arrow/row_wise_conversion_example.cc Outdated Show resolved Hide resolved
cpp/examples/arrow/row_wise_conversion_example.cc Outdated Show resolved Hide resolved
@pitrou pitrou closed this in 3cf9329 Sep 27, 2021
@bkmgit bkmgit deleted the bkmgit-row-conversion branch September 27, 2021 17:53
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
@bkmgit @pitrou @ViniciusSouzaRoque
ARROW-14054: [C++][Docs] Simplify C++ row conversion example
3ee7f6b 
- Add explanations for code example
- Print out entries
- make variable names clearer

Closes apache#11197 from bkmgit/bkmgit-row-conversion

Lead-authored-by: Benson Muite <bkmgit@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amol- amol- amol- left review comments

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkmgit @pitrou @amol-