ARROW-14173: [IR] Allow typed null literals to be represented #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
requested changes
Sep 29, 2021
There was a problem hiding this comment.
To avoid repetition of information in Literal::type, we should also remove fields
DurationLiteral::unit(and all other unit fields from the temporal literals)TimestampLiteral::timezoneStructLiteralField::name(field names are part of a struct type)DecimalLiteral::scale, precisionFixedSizeBinaryLiteral::size
cpcloud
force-pushed
the
ARROW-14173
branch
from
5817712
to
41829ff
Compare
bkietz
approved these changes
Sep 30, 2021
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Closes apache#11271 from cpcloud/ARROW-14173 Authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.