New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-1585/ARROW-1586: [PYTHON] serialize_pandas roundtrip loses columns name #1161

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cpcloud
Contributor

cpcloud commented Oct 4, 2017

This PR also adds support for MultiIndex columns.

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 4, 2017

Member

Can you rebase this on upstream?

Member

wesm commented Oct 4, 2017

Can you rebase this on upstream?

@cpcloud

This comment has been minimized.

Show comment
Hide comment
@cpcloud

cpcloud Oct 4, 2017

Contributor

Yep, on it.

Contributor

cpcloud commented Oct 4, 2017

Yep, on it.

@wesm

How hard would it be to handle ARROW-1585 (integer columns) in this?

Show outdated Hide outdated python/pyarrow/pandas_compat.py
@cpcloud

This comment has been minimized.

Show comment
Hide comment
@cpcloud

cpcloud Oct 4, 2017

Contributor

I think I can handle ARROW-1585 in this PR.

Contributor

cpcloud commented Oct 4, 2017

I think I can handle ARROW-1585 in this PR.

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 4, 2017

Member

Odd failure. the manylinux1 build is using pandas 0.20.1 in case it's hitting a pandas bug

Member

wesm commented Oct 4, 2017

Odd failure. the manylinux1 build is using pandas 0.20.1 in case it's hitting a pandas bug

@cpcloud cpcloud changed the title from ARROW-1586: [PYTHON] serialize_pandas roundtrip loses columns name to ARROW-1585/ARROW-1586: [PYTHON] serialize_pandas roundtrip loses columns name Oct 5, 2017

@wesm

wesm approved these changes Oct 6, 2017

+1, modulo minor comment

Show outdated Hide outdated python/pyarrow/pandas_compat.py
@cpcloud

This comment has been minimized.

Show comment
Hide comment
@cpcloud

cpcloud Oct 6, 2017

Contributor

@wesm This now handles categorical and datetimetz dtypes in column indexes.

Contributor

cpcloud commented Oct 6, 2017

@wesm This now handles categorical and datetimetz dtypes in column indexes.

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 6, 2017

Member

Sweet thanks!!!

Member

wesm commented Oct 6, 2017

Sweet thanks!!!

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 6, 2017

Member

This is failing on py2 =|

Member

wesm commented Oct 6, 2017

This is failing on py2 =|

@cpcloud

This comment has been minimized.

Show comment
Hide comment
@cpcloud

cpcloud Oct 7, 2017

Contributor

@wesm This is now passing on Travis. Waiting for appveyor to start: https://ci.appveyor.com/project/cpcloud/arrow/build/1.0.329

Contributor

cpcloud commented Oct 7, 2017

@wesm This is now passing on Travis. Waiting for appveyor to start: https://ci.appveyor.com/project/cpcloud/arrow/build/1.0.329

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 7, 2017

Member

Sweet, will keep an eye on the build

Member

wesm commented Oct 7, 2017

Sweet, will keep an eye on the build

@asfgit asfgit closed this in e31c2e3 Oct 7, 2017

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Oct 7, 2017

Member

Thanks!

Member

wesm commented Oct 7, 2017

Thanks!

@cpcloud cpcloud deleted the cpcloud:ARROW-1586 branch Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment