Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-587: Add fix version to PR merge tool #1248

Closed
wants to merge 4 commits into from
Closed

Conversation

wesm
Copy link
Member

@wesm wesm commented Oct 25, 2017

This was ported from parquet-mr/parquet-cpp and modified to work in Python 2 and 3

Change-Id: Id2b5e0a9fd45e44625a8c4094f61d41ed272234e
Change-Id: I901e62a57a1a3dd38a346f4a4bde79bd347c7d2d
@wesm
Copy link
Member Author

wesm commented Oct 26, 2017

Tried merging #1245 but there was a bug. Will keep at it until this script is right

Change-Id: I6e779d4d79927673f066db329decdf010ea5f4e9
Change-Id: I1aeee2e73e34819493837e1388bab57dc7ac8067
@wesm
Copy link
Member Author

wesm commented Oct 26, 2017

OK, this is good to go

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Are these fixes relevant for parquet-cpp, too? Can you port them there?

@wesm
Copy link
Member Author

wesm commented Oct 26, 2017

Yeah, we should do that because parquet-cpp is Python 2 only

@wesm
Copy link
Member Author

wesm commented Oct 26, 2017

opened ARROW-1739 about fixing the broken build (unrelated to this patch)

@wesm wesm closed this in 7abaa00 Oct 26, 2017
@wesm wesm deleted the ARROW-587 branch October 26, 2017 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants