Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16709: [Docs][Python] Add how to run doctests to the developer guide #13325

Merged
merged 4 commits into from Jun 8, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Jun 7, 2022

This PR adds content to the documentation about running doctest on PyArrow docstring examples.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just some minor suggestions

docs/source/developers/python.rst Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
docs/source/developers/python.rst Outdated Show resolved Hide resolved
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (aside from @pitrou's comments)

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlenkaF ! I've tried to re-run the cancelled doc CI, hopefully it'll be green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants