Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-1992: [C++/Python] Fix segfault when string to categorical empty string array #1508

Conversation

@Licht-T
Copy link
Contributor

commented Jan 25, 2018

This closes ARROW-1992.

const uint8_t* value = data + position; \
const uint8_t* value = data; \
if (value != &empty_value) { \
value += position; \

This comment has been minimized.

Copy link
@wesm

wesm Jan 25, 2018

Member

When this case comes up, position is always going to be 0, so we could maybe handle this by substituting a dummy static buffer for data above.

@Licht-T Licht-T force-pushed the Licht-T:fix-segfault-when-string_to_categorical-empty-string-array branch from d3a842b to afea4be Jan 25, 2018
@Licht-T

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2018

Thanks @wesm, fixed!

@wesm
wesm approved these changes Jan 25, 2018
Copy link
Member

left a comment

+1, thanks @Licht-T!

@xhochy
xhochy approved these changes Jan 28, 2018
Copy link
Member

left a comment

+1, failure is only due to Thrift

@xhochy xhochy closed this in d322634 Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.