Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2276: [Python] Expose buffer protocol on Tensor #1741

Closed

Conversation

Projects
None yet
2 participants
@pitrou
Copy link
Contributor

commented Mar 13, 2018

Also add a bit_width property to the DataType class.

@pitrou pitrou force-pushed the pitrou:ARROW-2276-tensor-buffer-protocol branch from fca0747 to e2dfe6d Mar 13, 2018

@xhochy

xhochy approved these changes Mar 20, 2018

Copy link
Member

left a comment

+1, LGTM

ARROW-2276: [Python] Expose buffer protocol on Tensor
Also add a bit_width property to the DataType class.

@pitrou pitrou force-pushed the pitrou:ARROW-2276-tensor-buffer-protocol branch from e2dfe6d to 104388a Apr 4, 2018

@pitrou

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2018

@pitrou pitrou closed this in 640fc83 Apr 4, 2018

@pitrou pitrou deleted the pitrou:ARROW-2276-tensor-buffer-protocol branch Apr 4, 2018

@pitrou

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2018

Thanks for the review, @xhochy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.