New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-1731: [Python] Add columns selector in Table.from_array #1924

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@samuelsinayoko

samuelsinayoko commented Apr 21, 2018

Fixes both ARROW-1731 and ARROW-1388

@xhochy

This comment has been minimized.

Member

xhochy commented Apr 21, 2018

@samuelsinayoko @Gatisseja Can you change the PR title to have the actual change as text and be prefixed with ARROW-1731: ?

@xhochy

This comment has been minimized.

Member

xhochy commented Apr 21, 2018

One nitpick from flake8:

+flake8 --count --config=/home/travis/build/apache/arrow/python/.flake8.cython /home/travis/build/apache/arrow/python/pyarrow
/home/travis/build/apache/arrow/python/pyarrow/table.pxi:758:5: E303 too many blank lines (2)
1

@samuelsinayoko samuelsinayoko changed the title from Arrow 1731 ahl hackathon to ARROW-1731: add columns selector in Table.from_array Apr 21, 2018

for i, idx in enumerate(indices):
if i == 0:
table = self.remove_column(idx)

This comment has been minimized.

@pitrou

pitrou Apr 21, 2018

Contributor

A nit: if you write table = self before the loop, you can dispense with this special case.

This comment has been minimized.

@Gatisseja

Gatisseja Apr 21, 2018

Contributor

nice, I love it!

Gatisseja added some commits Apr 21, 2018

@pitrou pitrou changed the title from ARROW-1731: add columns selector in Table.from_array to ARROW-1731: [Python] Add columns selector in Table.from_array Apr 23, 2018

@pitrou

pitrou approved these changes Apr 23, 2018

This looks good to me.

@pitrou pitrou closed this in a5ae134 Apr 23, 2018

@pitrou

This comment has been minimized.

Contributor

pitrou commented Apr 23, 2018

@samuelsinayoko, do you have a JIRA id so that the issue can be assigned to you?

@samuelsinayoko

This comment has been minimized.

samuelsinayoko commented Apr 28, 2018

@pitrou am afraid I don't have a JIRA yet. How can I get one?

@Gatisseja

This comment has been minimized.

Contributor

Gatisseja commented Apr 28, 2018

@pitrou Me too please

@pitrou

This comment has been minimized.

Contributor

pitrou commented Apr 28, 2018

@samuelsinayoko @Gatisseja you can register on the Apache JIRA tracker at https://issues.apache.org/jira

Then you can have someone with administrator rights (such as @xhochy ) give you contributor status so that we can issues to you.

@Gatisseja

This comment has been minimized.

Contributor

Gatisseja commented Apr 28, 2018

Done. Profile is gatisseja on jira

@samuelsinayoko

This comment has been minimized.

samuelsinayoko commented Apr 29, 2018

@pitrou cool thanks, my profile is sinayoko in Jira

@xhochy

This comment has been minimized.

Member

xhochy commented May 1, 2018

@samuelsinayoko @Gatisseja Gave you both contributor status, you should be able to assign yourselves to ticket.

@samuelsinayoko

This comment has been minimized.

samuelsinayoko commented May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment