Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2668: [C++] Suppress -Wnull-pointer-arithmetic when compiling plasma/malloc.cc on clang #2099

Closed
wants to merge 1 commit into from

Conversation

@wesm
Copy link
Member

commented Jun 3, 2018

This generates a warning on clang-6 when using CHECKIN error level, so compiling with -Werror will fail without it.

Suppress -Wnull-pointer-arithmetic when compiling plasma/malloc.cc on…
… clang

Change-Id: I60b573cf3e559781e2b0a7628112b14b13d3a1af
@codecov-io

This comment has been minimized.

Copy link

commented Jun 3, 2018

Codecov Report

Merging #2099 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2099   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         230      230           
  Lines       40488    40488           
=======================================
  Hits        34979    34979           
  Misses       5509     5509

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a2207...13d7670. Read the comment docs.

@xhochy
xhochy approved these changes Jun 3, 2018
Copy link
Member

left a comment

+1, LGTM

@xhochy xhochy closed this in 3960db9 Jun 3, 2018

@xhochy xhochy deleted the wesm:ARROW-2668 branch Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.