Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2824: [GLib] Add garrow_decimal128_array_get_value() #2238

Conversation

Projects
None yet
2 participants
@shiro615
Copy link
Contributor

commented Jul 10, 2018

No description provided.

@kou
Copy link
Member

left a comment

It's almost good!
Can you confirm my comment?

{
auto arrow_array = garrow_array_get_raw(GARROW_ARRAY(array));
auto arrow_decimal128_array =
static_cast<arrow::Decimal128Array *>(arrow_array.get());

This comment has been minimized.

Copy link
@kou

kou Jul 11, 2018

Member

Ah, I missed it. We should use std::static_pointer_cast<arrow::Decimal128Array>(arrow_array) instead of static_cast<... *>(...get()).
Can you change the same code in format_value()?

@shiro615

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

@kou
Thank you for review.I fixed.Please review again.

@kou

kou approved these changes Jul 12, 2018

@kou kou closed this in e366604 Jul 12, 2018

@kou

This comment has been minimized.

Copy link
Member

commented Jul 12, 2018

Thanks!
I've merged!

@shiro615 shiro615 deleted the shiro615:glib-add-garrow-decimal128-array-get-value branch Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.