New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-423: Define BUILD_BYPRODUCTS for CMake 3.2+ #240

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@xhochy
Copy link
Member

xhochy commented Dec 14, 2016

No description provided.

@xhochy xhochy force-pushed the xhochy:ARROW-423 branch from 5641fb0 to 4c99ba2 Dec 14, 2016

@xhochy xhochy changed the title ARROW-423: Define BUILD_BYPRODCUTS for CMake 3.2+ ARROW-423: Define BUILD_BYPRODUCTS for CMake 3.2+ Dec 14, 2016

# source dir and don't try to install. See its README for
# details.
BUILD_IN_SOURCE 1
BUILD_BYPRODUCTS "${GTEST_STATIC_LIB}"

This comment has been minimized.

@wesm

wesm Dec 14, 2016

Member

Is there anyway to conditionally insert this argument and avoid the code duplication?

This comment has been minimized.

@xhochy

xhochy Dec 14, 2016

Member

If I'd knew a way, I would really have used it.

@wesm

wesm approved these changes Dec 15, 2016

@wesm

This comment has been minimized.

Copy link
Member

wesm commented Dec 15, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment