ARROW-3099: [C++] Add benchmark for number parsing #2456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there might be a missing include |
pitrou
force-pushed
the
ARROW-3099-benchmark-number-parsing
branch
from
d8daaeb
to
78734ee
Compare
Sample output here (gcc 7.3, Ubuntu 18.04): ``` --------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------- BM_IntegerParsing<Int8Type> 1393 ns 1393 ns 499140 5.47679M items/s BM_IntegerParsing<Int16Type> 1496 ns 1496 ns 470116 5.09902M items/s BM_IntegerParsing<Int32Type> 1660 ns 1660 ns 420510 4.59584M items/s BM_IntegerParsing<Int64Type> 2071 ns 2070 ns 338406 3.68531M items/s BM_IntegerParsing<UInt8Type> 1229 ns 1229 ns 568370 6.20627M items/s BM_IntegerParsing<UInt16Type> 1311 ns 1311 ns 533548 5.81873M items/s BM_IntegerParsing<UInt32Type> 1402 ns 1401 ns 498921 5.44415M items/s BM_IntegerParsing<UInt64Type> 1625 ns 1625 ns 428792 4.69486M items/s BM_FloatParsing<FloatType> 4501 ns 4501 ns 155621 1.69512M items/s BM_FloatParsing<DoubleType> 4632 ns 4632 ns 150996 1.64721M items/s ```
pitrou
force-pushed
the
ARROW-3099-benchmark-number-parsing
branch
from
e0ae1db
to
08bbf5d
Compare
|
AppVeyor build at https://ci.appveyor.com/project/pitrou/arrow/build/1.0.629 |
stephanie-wang
pushed a commit
to stephanie-wang/arrow
that referenced
this pull request
Aug 29, 2018
Sample output here (gcc 7.3, Ubuntu 18.04): ``` --------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------- BM_IntegerParsing<Int8Type> 1393 ns 1393 ns 499140 5.47679M items/s BM_IntegerParsing<Int16Type> 1496 ns 1496 ns 470116 5.09902M items/s BM_IntegerParsing<Int32Type> 1660 ns 1660 ns 420510 4.59584M items/s BM_IntegerParsing<Int64Type> 2071 ns 2070 ns 338406 3.68531M items/s BM_IntegerParsing<UInt8Type> 1229 ns 1229 ns 568370 6.20627M items/s BM_IntegerParsing<UInt16Type> 1311 ns 1311 ns 533548 5.81873M items/s BM_IntegerParsing<UInt32Type> 1402 ns 1401 ns 498921 5.44415M items/s BM_IntegerParsing<UInt64Type> 1625 ns 1625 ns 428792 4.69486M items/s BM_FloatParsing<FloatType> 4501 ns 4501 ns 155621 1.69512M items/s BM_FloatParsing<DoubleType> 4632 ns 4632 ns 150996 1.64721M items/s ``` Author: Antoine Pitrou <antoine@python.org> Closes apache#2456 from pitrou/ARROW-3099-benchmark-number-parsing and squashes the following commits: 08bbf5d <Antoine Pitrou> Try to fix integer conversion warning 60c4ac5 <Antoine Pitrou> Try to fix compile error e5dd04d <Antoine Pitrou> ARROW-3099: Add benchmark for number parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample output here (gcc 7.3, Ubuntu 18.04):