ARROW-387: [C++] Verify zero-copy Buffer slices from BufferReader retain reference to parent Buffer #266

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@wesm
Member
wesm commented Jan 2, 2017

This is stacked on top of the patch for ARROW-294, will rebase.

wesm added some commits Jan 2, 2017
@wesm wesm Base MemoryMappedFile implementation on common OSFile interface. Add …
…test case

for ARROW-340.

Change-Id: Iedbe5fe332dfb7007e7db8367b6adcbb73dbdecb
3928ab0
@wesm wesm Remove duplicated includes
Change-Id: I4e165909757790748b6d1aa8b2842963a4432e4f
42a83a4
@wesm wesm Verify BufferReader passes on ownership of parent buffer to zero-copy…
… slices

Change-Id: I6a14985ea8d2c6ce745206fe7db7228b4b5dcdbd
061ef8b
@xhochy
xhochy approved these changes Jan 3, 2017 View changes

+1, LGTM

@asfgit asfgit pushed a commit that closed this pull request Jan 3, 2017
@wesm @xhochy wesm + xhochy ARROW-387: [C++] Verify zero-copy Buffer slices from BufferReader ret…
…ain reference to parent Buffer

This is stacked on top of the patch for ARROW-294, will rebase.

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes #266 from wesm/ARROW-387 and squashes the following commits:

061ef8b [Wes McKinney] Verify BufferReader passes on ownership of parent buffer to zero-copy slices
42a83a4 [Wes McKinney] Remove duplicated includes
3928ab0 [Wes McKinney] Base MemoryMappedFile implementation on common OSFile interface. Add test case for ARROW-340.
26140dc
@asfgit asfgit closed this in 26140dc Jan 3, 2017
@wesm wesm deleted the wesm:ARROW-387 branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment