Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3540: [Rust] Incorporate BooleanArray into PrimitiveArray #2778

Closed
wants to merge 1 commit into from

Conversation

@paddyhoran
Copy link
Contributor

paddyhoran commented Oct 17, 2018

Currently we have a specific implementation for BooleanArray (bit-packing), but due to the ArrowPrimitiveType trait which we use as a trait bound in many places PrimitiveArray<bool> is still a valid type. make_array actually uses PrimitiveArray<bool> which may be a bug but would be fixed by this PR anyway.

This PR moves the implementation of BooleanArray into PrimitiveArray<bool>, this would allow us to use the ArrayPrimitiveType trait as a bound more consistently. i.e. PrimitiveArrayBuilder<T> could return PrimitiveArray<T> instead of having a separate BooleanArrayBuilder.

cc @kszucs @sunchao @andygrove @crepererum

@crepererum

This comment has been minimized.

Copy link
Contributor

crepererum commented Oct 17, 2018

Look good to me, thanks :)

@kszucs
kszucs approved these changes Oct 17, 2018
Copy link
Member

kszucs left a comment

LGTM, Thanks!

@kszucs kszucs closed this in 8aea70c Oct 17, 2018
@paddyhoran paddyhoran deleted the paddyhoran:bool_array_updates branch Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.