Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-3640: [Go] implement Tensors #2860

Closed
wants to merge 2 commits into from
Closed

ARROW-3640: [Go] implement Tensors #2860

wants to merge 2 commits into from

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Oct 29, 2018

No description provided.

@sbinet sbinet changed the title Issue 3640 ARROW-3640: [Go] implement Tensors Oct 29, 2018
@codecov-io
Copy link

codecov-io commented Oct 29, 2018 •
edited

Codecov Report

Merging #2860 into master will decrease coverage by 18.94%.
The diff coverage is 93.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2860       +/-   ##
==========================================
- Coverage   87.55%   68.6%   -18.95%     
==========================================
  Files         411      54      -357     
  Lines       63818    2899    -60919     
==========================================
- Hits        55874    1989    -53885     
+ Misses       7870     832     -7038     
- Partials       74      78        +4
Impacted Files Coverage Δ
go/arrow/array/data.go 84.31% <0%> (-3.45%) ⬇️
go/arrow/array/table.go 100% <100%> (ø) ⬆️
go/arrow/array/record.go 100% <100%> (ø)
go/arrow/tensor/numeric.gen.go 100% <100%> (ø)
go/arrow/datatype_nested.go 94.73% <100%> (+0.29%) ⬆️
go/arrow/datatype_numeric.gen.go 50% <50%> (-20%) ⬇️
go/arrow/tensor/tensor.go 85.98% <85.98%> (ø)
go/arrow/schema.go 97.33% <97.33%> (-2.67%) ⬇️
python/pyarrow/ipc.pxi
... and 362 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fafd8...97a28c9. Read the comment docs.

@sbinet sbinet force-pushed the issue-3640 branch 3 times, most recently from 5896fed to e4d29ec Compare October 29, 2018 11:17
@sbinet
Copy link
Contributor Author

sbinet commented Oct 29, 2018

needs #2838 and #2847

PTAL @stuartcarnie

@sbinet sbinet force-pushed the issue-3640 branch 4 times, most recently from c71bd85 to 19630d3 Compare October 30, 2018 08:29
@sbinet sbinet mentioned this pull request Oct 30, 2018
Closed
stuartcarnie
stuartcarnie approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @sbinet 🎉

@stuartcarnie
Copy link
Contributor

@wesm LGTM

@wesm wesm closed this in 2cdc4d4 Oct 31, 2018
wesm pushed a commit that referenced this pull request Oct 31, 2018
@sbinet @wesm
ARROW-3637: [Go] implement Stringer for arrays
9fb776c 
needs #2860

Author: Sebastien Binet <binet@cern.ch>

Closes #2870 from sbinet/issue-3637 and squashes the following commits:

1e9c358 <Sebastien Binet> ARROW-3637:  implement Stringer for arrays
@sbinet sbinet deleted the issue-3640 branch November 1, 2018 10:46
@asfimport asfimport mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcarnie stuartcarnie stuartcarnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbinet @codecov-io @stuartcarnie