Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3796: [Rust] Add Example for PrimitiveArrayBuilder #2969

Closed
wants to merge 4 commits into from

Conversation

@paddyhoran
Copy link
Contributor

paddyhoran commented Nov 15, 2018

I will follow up with examples of ListArrayBuilder and BinaryBuilder when merged. The info in the readme keeps going out of date so it's probably better to build up the examples (which are tested by CI) and re-direct new users there.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #2969 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
+ Coverage   86.45%   86.46%   +0.01%     
==========================================
  Files         490      490              
  Lines       68920    68920              
==========================================
+ Hits        59583    59593      +10     
+ Misses       9247     9241       -6     
+ Partials       90       86       -4
Impacted Files Coverage Δ
go/arrow/math/uint64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/int64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/math_amd64.go 36.84% <0%> (+5.26%) ⬆️
go/arrow/memory/memory_amd64.go 42.85% <0%> (+14.28%) ⬆️
go/arrow/math/int64_avx2_amd64.go 100% <0%> (+100%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736b5b0...46699f9. Read the comment docs.

@kszucs
kszucs approved these changes Nov 15, 2018
Copy link
Member

kszucs left a comment

LGTM, thanks @paddyhoran!

@kszucs kszucs closed this in 1c8f8fc Nov 15, 2018
@paddyhoran paddyhoran deleted the paddyhoran:ARROW-3796 branch Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.