Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3885: [Rust] Release prepare step should increment Rust version #3096

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@andygrove
Copy link
Contributor

andygrove commented Dec 5, 2018

No description provided.

@wesm

This comment has been minimized.

Copy link
Member

wesm commented Dec 5, 2018

I wonder if this is something we could automate as part of the release process.

@andygrove

This comment has been minimized.

Copy link
Contributor Author

andygrove commented Dec 5, 2018

I will attempt to do that ... looks like it is easy enough with sed

@kou

This comment has been minimized.

Copy link
Member

kou commented Dec 5, 2018

I want to stop the current version sharing style. (Referring java/pom.xml from C++, Python, C, Ruby, ....)
It introduces complexity. For example, we generates version.rb dynamically to create a Ruby package: https://github.com/apache/arrow/blob/master/ruby/red-arrow/version.rb

I think that we can just replace all versions in cpp/CMakeLists.txt, python/setup.py, c_glib/configure.ac, ruby/*/lib/*/version.rb, rust/Cargo.toml, ... by sed in the release process.

If this change is acceptable, I'll open a JIRA issue.

Note that I don't think this change should be done in this pull request. This pull request only needs to update version for Rust.

@andygrove

This comment has been minimized.

Copy link
Contributor Author

andygrove commented Dec 5, 2018

@wesm this is ready for review now

@andygrove andygrove changed the title ARROW-3885: [Rust] Update Rust version to 0.12.0 ARROW-3885: [Rust] Release prepare step should increment Rust version Dec 5, 2018

@wesm

This comment has been minimized.

Copy link
Member

wesm commented Dec 5, 2018

@kou I agree with you. One complexity is that we need to be able to produce development version numbers using setuptools_scm when building the Python wheels. Feel free to open a JIRA and we can discuss

@kou

This comment has been minimized.

Copy link
Member

kou commented Dec 5, 2018

I've opened https://issues.apache.org/jira/browse/ARROW-3938 for general version update.

@kou

This comment has been minimized.

Copy link
Member

kou commented Dec 7, 2018

Can we resolve the current CI error by rebasing on master?
2f4af26 is included in master.

@andygrove

This comment has been minimized.

Copy link
Contributor Author

andygrove commented Dec 10, 2018

@wesm @kou This is ready for review again

@kou

This comment has been minimized.

Copy link
Member

kou commented Dec 10, 2018

Thanks. CI is green. But GitHub says "This branch cannot be rebased due to conflicts". I'll rebase on master again.

@kou kou force-pushed the andygrove:ARROW-3885 branch from 6ef795f to 7d15ee7 Dec 10, 2018

@kou

kou approved these changes Dec 10, 2018

Copy link
Member

kou left a comment

CI is green.
I'll merge this.

@kou kou closed this in 1dc906e Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.