Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4030: [CI] Use travis_terminate in more script commands to fail faster #3226

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Dec 19, 2018

I had done this partially in ARROW-3803, but I reviewed again and tried to apply this more consistently.

Note it is not necessary to use this in the last command in the script: block

Change-Id: I8f7d0784609f0516f9ce8a1b73cd6a8914552f6d
@codecov-io
Copy link

Codecov Report

Merging #3226 into master will increase coverage by 20.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3226       +/-   ##
===========================================
+ Coverage   68.06%   88.17%   +20.11%     
===========================================
  Files         422      535      +113     
  Lines       52703    72637    +19934     
===========================================
+ Hits        35870    64048    +28178     
+ Misses      16730     8482     -8248     
- Partials      103      107        +4
Impacted Files Coverage Δ
go/arrow/math/int64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/uint64_avx2_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_amd64.go 28.57% <0%> (-14.29%) ⬇️
go/arrow/math/math_amd64.go 31.57% <0%> (-5.27%) ⬇️
cpp/src/parquet/thrift.h 100% <0%> (ø) ⬆️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
cpp/src/gandiva/expression_registry.h 100% <0%> (ø) ⬆️
... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d089643...a04c11e. Read the comment docs.

@wesm
Copy link
Member Author

wesm commented Dec 19, 2018

+1

@wesm wesm closed this in 320621d Dec 19, 2018
cav71 pushed a commit to cav71/arrow that referenced this pull request Dec 22, 2018
… faster

I had done this partially in ARROW-3803, but I reviewed again and tried to apply this more consistently.

Note it is not necessary to use this in the last command in the script: block

Author: Wes McKinney <wesm+git@apache.org>

Closes apache#3226 from wesm/ARROW-4030 and squashes the following commits:

a04c11e <Wes McKinney> Use travis_terminate in more builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants