GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one #35220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: C++ - Gandiva
awaiting committer review
|
@github-actions crossbow submit -g verify-rc-source java-jars |
|
Revision: 10ffcec Submitted crossbow builds: ursacomputing/crossbow @ actions-cc7caa00a4
|
|
+1 |
raulcd
pushed a commit
that referenced
this pull request
Apr 19, 2023
…led one (#35220) ### Rationale for this change If we use bundled Zstandared, we should not find system Zstandard for Gandiva. Because it's always failed. ### What changes are included in this PR? Add a missing check whether we're using system Zstandard or bundled Zstandard. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #35205 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
Benchmark runs are scheduled for baseline = d7c5e4c and contender = ce60f2f. ce60f2f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…e bundled one (apache#35220) ### Rationale for this change If we use bundled Zstandared, we should not find system Zstandard for Gandiva. Because it's always failed. ### What changes are included in this PR? Add a missing check whether we're using system Zstandard or bundled Zstandard. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35205 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…e bundled one (apache#35220) ### Rationale for this change If we use bundled Zstandared, we should not find system Zstandard for Gandiva. Because it's always failed. ### What changes are included in this PR? Add a missing check whether we're using system Zstandard or bundled Zstandard. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35205 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…e bundled one (apache#35220) ### Rationale for this change If we use bundled Zstandared, we should not find system Zstandard for Gandiva. Because it's always failed. ### What changes are included in this PR? Add a missing check whether we're using system Zstandard or bundled Zstandard. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35205 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we use bundled Zstandared, we should not find system Zstandard for Gandiva.
Because it's always failed.
What changes are included in this PR?
Add a missing check whether we're using system Zstandard or bundled Zstandard.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.