ARROW-4457: [Python] Allow creating Decimal array from Python ints #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression apparently introduced in 0.11.0
|
As for the explanation, it seems at some point we were doing no type checking and blindly converted the Python input to a string. That was supposed to work for Python decimals but incidentally also did the right thing for Python integers (though untested). Then I or someone else must have added type checking :-) |
|
Yeah, I figured this was working before "by accident" =) |
trxcllnt
pushed a commit
to trxcllnt/arrow
that referenced
this pull request
Feb 12, 2019
This is a regression apparently introduced in 0.11.0 Author: Antoine Pitrou <antoine@python.org> Closes apache#3612 from pitrou/ARROW-4457-decimal-from-pyint and squashes the following commits: 5d0e767 <Antoine Pitrou> ARROW-4457: Allow creating Decimal array from Python ints
trxcllnt
pushed a commit
to trxcllnt/arrow
that referenced
this pull request
Feb 12, 2019
This is a regression apparently introduced in 0.11.0 Author: Antoine Pitrou <antoine@python.org> Closes apache#3612 from pitrou/ARROW-4457-decimal-from-pyint and squashes the following commits: 5d0e767 <Antoine Pitrou> ARROW-4457: Allow creating Decimal array from Python ints
tanyaschlusser
pushed a commit
to tanyaschlusser/arrow
that referenced
this pull request
Feb 21, 2019
This is a regression apparently introduced in 0.11.0 Author: Antoine Pitrou <antoine@python.org> Closes apache#3612 from pitrou/ARROW-4457-decimal-from-pyint and squashes the following commits: 5d0e767 <Antoine Pitrou> ARROW-4457: Allow creating Decimal array from Python ints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression apparently introduced in 0.11.0