GH-36837: [CI][RPM] Use multi-cores to install gems #36838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit almalinux-* amazon-linux-* centos-* |
|
|
|
Revision: 8c2d871 Submitted crossbow builds: ursacomputing/crossbow @ actions-6a1e2f84f7
|
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2a9c8b1. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
### Rationale for this change We may reduce test time by using multi-cores to install gems. ### What changes are included in this PR? `gem install` with `MAKEFLAGS=-j$(nproc)` uses multi-cores when building extension libraries. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36837 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change We may reduce test time by using multi-cores to install gems. ### What changes are included in this PR? `gem install` with `MAKEFLAGS=-j$(nproc)` uses multi-cores when building extension libraries. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36837 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We may reduce test time by using multi-cores to install gems.
What changes are included in this PR?
gem installwithMAKEFLAGS=-j$(nproc)uses multi-cores when building extension libraries.Are these changes tested?
Yes.
Are there any user-facing changes?
No.