Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4778: [C++/Python] manylinux1: Update Thrift to 0.12.0 #3823

Closed
wants to merge 2 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Mar 6, 2019

No description provided.

@kszucs
Copy link
Member

kszucs commented Mar 6, 2019

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhochy
Copy link
Member Author

xhochy commented Mar 6, 2019

@xhochy are You going to tag it as https://github.com/apache/arrow/blob/master/dev/tasks/python-wheels/travis.linux.yml#L48 ?

I'm not sure what you're asking me? ;)

@kszucs
Copy link
Member

kszucs commented Mar 6, 2019

After I merge this PR will You tag quay.io/xhochy/arrow_manylinux1_x86_64_base:ARROW-4778 as quay.io/xhochy/arrow_manylinux1_x86_64_base:llvm-7-manylinux1

OR

You update the crossbow task to use ARROW-4778 docker tag BEFORE I merge :)

@xhochy
Copy link
Member Author

xhochy commented Mar 6, 2019

I wasn't aware anymore that crossbow also depends on the image name. Do you have an idea for a more central place that crossbow and Travis both use the same image name source? It has really been annoying how often we forgot to adjust one of the three places.

@kszucs
Copy link
Member

kszucs commented Mar 6, 2019

Perhaps wrap the big docker command with a script and call that script from both travis and crossbow...

@wesm wesm closed this in b77b662 Mar 6, 2019
@kszucs
Copy link
Member

kszucs commented Mar 6, 2019

Created issue for it: https://issues.apache.org/jira/browse/ARROW-4790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants