Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4881: [C++] remove references to ARROW_BUILD_TOOLCHAIN #3993

Conversation

@bkietz
Copy link
Contributor

bkietz commented Mar 20, 2019

ARROW_BUILD_TOOLCHAIN has been superceded since the cmake refactor, but a few scripts still set and use it.

@bkietz

This comment has been minimized.

Copy link
Contributor Author

bkietz commented Mar 20, 2019

Should this be python=%PYTHON% like that

@pitrou

This comment has been minimized.

Copy link
Contributor

pitrou commented Mar 21, 2019

Should this be python=%PYTHON% like that

Since Python is already installed by conda create, you can probably delete the python=3.6 from the conda install invocation.

@bkietz

This comment has been minimized.

Copy link
Contributor Author

bkietz commented Mar 21, 2019

@kszucs Travis failed because brew couldn't find llvm@7 https://travis-ci.org/apache/arrow/jobs/509210161#L4002 could you restart this please

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Mar 21, 2019

That happened with multiple PRs, brew has even hit github's abuse detection system - I'd fail again.
Probably caused by the recent llvm upgrade https://github.com/Homebrew/homebrew-core/blob/master/Formula/llvm.rb

@kszucs
kszucs approved these changes Mar 21, 2019
Copy link
Member

kszucs left a comment

LGTM

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Mar 21, 2019

Created issue for the travis error: https://issues.apache.org/jira/browse/ARROW-4986

@kszucs kszucs closed this in 3bf1e39 Mar 21, 2019
@bkietz bkietz deleted the bkietz:4881-bundle-zlib-CMake-function-still-uses-AR branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.