Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5183: [CI] Fix AppVeyor failure #4169

Closed

Conversation

@pitrou
Copy link
Contributor

pitrou commented Apr 18, 2019

Boost 0.70.0 package is buggy on MinGW, and there's no easy way of downgrading without provoking other issues, so I'm just disabling MinGW entries.

@pitrou

This comment has been minimized.

Copy link
Contributor Author

pitrou commented Apr 18, 2019

If this doesn't solve the issue I will probably simply disable the MinGW entries in AppVeyor @kou

Boost 0.70.0 package is buggy on MinGW, and there's no easy way of downgrading
without provoking other issues, so I'm just disabling MinGW entries.
@pitrou pitrou force-pushed the pitrou:ARROW-5183-appveyor-mingw-failure branch from 33f14f0 to 3711a88 Apr 18, 2019
@pitrou pitrou changed the title ARROW-5183: [CI] Fix MinGW failure ARROW-5183: [CI] Fix AppVeyor failure Apr 18, 2019
@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Apr 18, 2019

SGTM until @kou can take a look.

@pitrou pitrou closed this in 0e99fc4 Apr 18, 2019
@pitrou pitrou deleted the pitrou:ARROW-5183-appveyor-mingw-failure branch Apr 18, 2019
@kou

This comment has been minimized.

Copy link
Member

kou commented Apr 18, 2019

FindBoost.cmake will provide Boost_<C>_LIBRARY_{DEBUG,RELEASE} https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindBoost.cmake#L70-71 and Boost::<C> https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindBoost.cmake#L77-79 .

But if BoostConfig.cmake provided by Boost is used https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindBoost.cmake#L252-280 , the BoostConfig.cmake https://github.com/boostorg/boost_install/blob/develop/BoostConfig.cmake only provides Boost::<C>. So using Boost::<C> is more portable than using Boost_<C>_LIBRARY_{DEBUG,RELEASE}.

See #4173.

mattias01 added a commit to mattias01/arrow that referenced this pull request May 21, 2019
Boost 0.70.0 package is buggy on MinGW, and there's no easy way of downgrading without provoking other issues, so I'm just disabling MinGW entries.

Author: Antoine Pitrou <antoine@python.org>

Closes apache#4169 from pitrou/ARROW-5183-appveyor-mingw-failure and squashes the following commits:

3711a88 <Antoine Pitrou> ARROW-5183:  Fix AppVeyor failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.