Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4194: [Format][Docs] Remove duplicated / out-of-date logical type information from documentation #4523

Closed
wants to merge 1 commit into from

Conversation

@wesm
Copy link
Member

wesm commented Jun 12, 2019

This documentation is not being properly maintained and it duplicates the point-of-truth information in format/Schema.fbs.

I also split out the integration-testing related JSON stuff to a separate section and opened ARROW-5563 about sprucing that up.

…tation and direct readers to Schema.fbs
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #4523 into master will decrease coverage by 23.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #4523       +/-   ##
==========================================
- Coverage   88.29%   64.8%   -23.49%     
==========================================
  Files         847     475      -372     
  Lines      104639   61040    -43599     
  Branches     1253       0     -1253     
==========================================
- Hits        92386   39555    -52831     
- Misses      12008   21485     +9477     
+ Partials      245       0      -245
Impacted Files Coverage Δ
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/extension_type.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/compare.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/util-internal.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
... and 600 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c753c4...2764126. Read the comment docs.

@wesm

This comment has been minimized.

Copy link
Member Author

wesm commented Jun 12, 2019

+1

@wesm wesm closed this in c2da956 Jun 12, 2019
@wesm wesm deleted the wesm:remove-outdated-metadata-stuff branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.