Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
ARROW-5736: [Format][C++] Support small bit-width indices in sparse tensor #5290
@@ Coverage Diff @@ ## master #5290 +/- ## ========================================== + Coverage 88.72% 88.72% +<.01% ========================================== Files 945 945 Lines 124009 124086 +77 Branches 1437 1437 ========================================== + Hits 110024 110093 +69 - Misses 13623 13631 +8 Partials 362 362
pprudhvi added a commit to pprudhvi/arrow that referenced this pull request
Sep 16, 2019
…ensor I'd like to enable all integer types to become the value type of sparse tensor index. Closes apache#5290 from mrkn/ARROW-5736 and squashes the following commits: b0be574 <Kenta Murata> Add check SparseCOOIndex::coords_->ndim() in the constructor ad725c2 <Kenta Murata> Remove needless include 84e6726 <Kenta Murata> Fix typo 76e5ca7 <Kenta Murata> Increase coverage rate 2226c9a <Kenta Murata> Fix compile errors on MSVC f1cf53f <Kenta Murata> Insert an explicit down cast 56ffc1b <Kenta Murata> Add #include <limits> a3fd502 <Kenta Murata> Refactoring f0222ab <Kenta Murata> Suppor reading and writing f2a1920 <Kenta Murata> Use fixtures in TestSparseCSRMatrix 4079906 <Kenta Murata> Refactoring of TestSparseCOOTensor 980cf96 <Kenta Murata> Refactoring becc425 <Kenta Murata> Enable all integer types to become the value type of SparseCOOIndex 46acdb1 <Kenta Murata> Refactor ipc-read-write-test with a typed test case b0053de <Kenta Murata> Add assertions for dim_names and dim_name b7b47c7 <Kenta Murata> Refactor sparse_tensor-test with a typed test case 45be5c4 <Kenta Murata> Support reading and writing row-major SparseCOOIndex 33b6d1f <Kenta Murata> Make SparseCOOIndex support row-major index 5f8ba9f <Kenta Murata> Add indicesStrides in SparseTensorIndexCOO 5ec7e65 <Kenta Murata> Modify the comment of SparseTensorIndexCOO 8a0f65b <Kenta Murata> Add type fields of sparse index types Authored-by: Kenta Murata <firstname.lastname@example.org> Signed-off-by: Antoine Pitrou <email@example.com>
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.